Skip to content

release: prepare v1.0.1-rc.0#1997

Merged
stevvooe merged 1 commit intocontainerd:release/1.0from
stevvooe:release-1.0.1-rc.0
Jan 11, 2018
Merged

release: prepare v1.0.1-rc.0#1997
stevvooe merged 1 commit intocontainerd:release/1.0from
stevvooe:release-1.0.1-rc.0

Conversation

@stevvooe
Copy link
Copy Markdown
Member

@stevvooe stevvooe commented Jan 11, 2018

Signed-off-by: Stephen J Day [email protected]

Review Checklist:

  • Release notes are good
  • Version updated
  • Right revision in release branch

Tag will be pushed after successful build, merge, build of this branch.

@stevvooe stevvooe added this to the 1.0.1 milestone Jan 11, 2018
Signed-off-by: Stephen J Day <[email protected]>
Comment thread releases/v1.0.1-rc.0.toml
@@ -0,0 +1,24 @@
# commit to be tagged for new release
commit = "HEAD"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work from a sub-branch?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, HEAD always points to the current branch reference.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1997 into release/1.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.0    #1997   +/-   ##
============================================
  Coverage        50.54%   50.54%           
============================================
  Files               81       81           
  Lines             7136     7136           
============================================
  Hits              3607     3607           
  Misses            2838     2838           
  Partials           691      691
Flag Coverage Δ
#linux 50.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc882c...5a09fd3. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevvooe stevvooe merged commit 27cbd2a into containerd:release/1.0 Jan 11, 2018
@stevvooe stevvooe deleted the release-1.0.1-rc.0 branch January 11, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants