[release 1.0] Remove reaper from containerd daemon#1996
Merged
stevvooe merged 1 commit intocontainerd:release/1.0from Jan 11, 2018
Merged
[release 1.0] Remove reaper from containerd daemon#1996stevvooe merged 1 commit intocontainerd:release/1.0from
stevvooe merged 1 commit intocontainerd:release/1.0from
Conversation
This allows other packages and plugins to easily exec things without racing with the reaper. The reaper is mostly needed in the shim but can be removed in containerd in favor of the `exec.Cmd` apis Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #1996 +/- ##
===============================================
+ Coverage 50.51% 50.54% +0.02%
===============================================
Files 81 81
Lines 7140 7136 -4
===============================================
Hits 3607 3607
+ Misses 2842 2838 -4
Partials 691 691
Continue to review full report at Codecov.
|
mlaventure
approved these changes
Jan 11, 2018
Contributor
mlaventure
left a comment
mlaventure
left a comment
There was a problem hiding this comment.
LGTM
It's not a cherry-pick though ;-)
Member
Author
|
Had to fix merge conflicts |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows other packages and plugins to easily exec things without
racing with the reaper.
The reaper is mostly needed in the shim but can be removed in containerd
in favor of the
exec.CmdapisSigned-off-by: Michael Crosby [email protected]