Skip to content

rootfs: remove upper snapshot after use#1953

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
jessvalarezo:diff-key-bug
Jan 3, 2018
Merged

rootfs: remove upper snapshot after use#1953
crosbymichael merged 1 commit intocontainerd:masterfrom
jessvalarezo:diff-key-bug

Conversation

@jessvalarezo
Copy link
Copy Markdown
Contributor

The remove function should take the generated upperKey instead of the lowerKey which has already been handled in L28.

Signed-off-by: Jess Valarezo [email protected]

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1953   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files          93       93           
  Lines        9240     9240           
=======================================
  Hits         4246     4246           
  Misses       4293     4293           
  Partials      701      701
Flag Coverage Δ
#linux 50.63% <ø> (ø) ⬆️
#windows 40.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e479165...5bc0c43. Read the comment docs.

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 556c46d into containerd:master Jan 3, 2018
@jessvalarezo jessvalarezo deleted the diff-key-bug branch January 3, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants