Add zfs and aufs snapshotters in tree#1934
Add zfs and aufs snapshotters in tree#1934crosbymichael wants to merge 3 commits intocontainerd:masterfrom
Conversation
This moves the aufs snapshotter from the separate repo to be in the main containerd tree Signed-off-by: Michael Crosby <[email protected]>
This adds the zfs snapshotter in the main containerd tree. Signed-off-by: Michael Crosby <[email protected]>
|
LGTM Looks like the build needs to install the zfs tools. |
|
Sorry but I am -1 on this, if other disagree then I won't hold it up though. The advantage of bringing these into the tree is around testing, however both of this drivers will require special kernel modules in order to work. Before we only included overlay and btrfs because of their inclusion in the kernel. If we want to compile these in, that is fine, but why can't we just get away with vendoring? As for CI, as I was saying, these require special configuration anyways so warrant having their own project with their own special CI setup. |
Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
snapshotters
branch
from
e6c1bea to
0622247
Compare
|
I personally agree with @dmcgowan I think, instead we may want to figure out a way to have plugins be added easily to |
|
@dmcgowan ok, good point. |
reopened #1615 , but feel free to close |
5 participants
After this is merged we will be able to delete the zfs and aufs projects under the containerd org.