[cherry-pick] Fix image pull after a failure#1918
Merged
mlaventure merged 1 commit intocontainerd:release/1.0from Dec 15, 2017
Merged
[cherry-pick] Fix image pull after a failure#1918mlaventure merged 1 commit intocontainerd:release/1.0from
mlaventure merged 1 commit intocontainerd:release/1.0from
Conversation
When resuming from a failed pull writer.Truncate() was not seeking to the proper position in the file. This caused writes to happen after the previously written content, instead of at the start of the file. Signed-off-by: Daniel Nephin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #1918 +/- ##
==============================================
+ Coverage 50.66% 50.7% +0.04%
==============================================
Files 81 81
Lines 7159 7161 +2
==============================================
+ Hits 3627 3631 +4
+ Misses 2849 2845 -4
- Partials 683 685 +2
Continue to review full report at Codecov.
|
Member
|
Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resuming from a failed pull writer.Truncate() was not
seeking to the proper position in the file. This caused writes to
happen after the previously written content, instead of at the start
of the file.
Signed-off-by: Daniel Nephin [email protected]