Fix a containerd deadlock.#1907
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Dec 12, 2017
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 89 89
Lines 8830 8830
=======================================
Hits 4176 4176
Misses 3968 3968
Partials 686 686
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this issue during cluster bootstrapping.
If containerd is terminated with
pkill containerdbefore it is fully bootstrapped, it may fall into a deadlock.The reason is that the server channel size is 0. If
handleSignalsexits early, no one is going to consume the message in channel, andserverC <- serverwill stuck forever.If this makes sense, we should cherrypick into 1.0. @crosbymichael
Signed-off-by: Lantao Liu [email protected]