@dnephin Approach looks good. Any side effects to this change?

I've poked the build, let's see if the new flag gets picked up.

No side effects I can think of

It looks like make coverage is still printing all the packages, let me see if I can fix that before we merge

Codecov Report

Merging #1904 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1904      +/-   ##
==========================================
- Coverage   47.23%   47.19%   -0.04%     
==========================================
  Files          91       91              
  Lines        8964     8964              
==========================================
- Hits         4234     4231       -3     
- Misses       4031     4033       +2     
- Partials      699      700       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d1e55...274ce69. Read the comment docs.

Apparently go test -i prints to stderr , not stdout, so changed to 2> /dev/null for that line.

@dnephin Should we remove -v from TESTFLAGS? That is by far the biggest offender and makes it hard to debug in CI.

I like having -v to know what test is actually running. All it does is print the test name.

All it does is print the test name.

Doesn't it also print logging, as well?

Doesn't it also print logging, as well?

Oh, yes it does, I never do fmt.Print* in tests, so I forgot. Well, if we want to keep those print, I guess we should remove -v then

I personally like seeing the test names in CI, I think that output has value. From what I can see there isn't much stdout/stderr in the output right now. There are still a few t.Log() lines which could be removed

LGTM

Marking this as cherry-pick so we can have faster builds on 1.0 release builds.