Skip to content

docs: update BUILDING and README#1878

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
jessvalarezo:docs-updates
Dec 5, 2017
Merged

docs: update BUILDING and README#1878
stevvooe merged 1 commit intocontainerd:masterfrom
jessvalarezo:docs-updates

Conversation

@jessvalarezo
Copy link
Copy Markdown
Contributor

@jessvalarezo jessvalarezo commented Dec 5, 2017 •
edited
Loading

Partly addresses #1819

  • makes BUILDING.md the developer quick start
  • organizes BUILDING.md

Signed-off-by: Jess Valarezo [email protected]

AkihiroSuda
AkihiroSuda reviewed Dec 5, 2017
View reviewed changes
Comment thread BUILDING.md Outdated
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build tag -> build tag no_btrfs

AkihiroSuda
AkihiroSuda reviewed Dec 5, 2017
View reviewed changes
Comment thread BUILDING.md Outdated
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins loading -> loading plugins

@jessvalarezo jessvalarezo force-pushed the docs-updates branch 2 times, most recently from 8659572 to d7ddcdd Compare December 5, 2017 03:45
@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Dec 5, 2017

LGTM

@stevvooe stevvooe closed this Dec 5, 2017
@stevvooe stevvooe reopened this Dec 5, 2017
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Dec 5, 2017

LGTM

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Dec 5, 2017

CI failing

0.08s$ GIT_CHECK_EXCLUDE="./vendor" TRAVIS_COMMIT_RANGE="${TRAVIS_COMMIT_RANGE/.../..}" make dco
git-validation -q -run DCO,short-subject,dangling-whitespace
 d7ddcdd - FAIL - has whitespace errors. See `git show --check d7ddcddc33f78fc3a83cae0b525108d9d503a7cd`.
1 commits to fix
make: *** [dco] Error 1
The command "GIT_CHECK_EXCLUDE="./vendor" TRAVIS_COMMIT_RANGE="${TRAVIS_COMMIT_RANGE/.../..}" make dco" exited with 2.

LGTM when green

@stevvooe stevvooe merged commit 2ff2a70 into containerd:master Dec 5, 2017
@jessvalarezo jessvalarezo deleted the docs-updates branch January 10, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jessvalarezo @stevvooe @dmcgowan @AkihiroSuda