Skip to content

output unmount error when unmount fail in diff.Apply#1877

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
yanxuean:add-unmount-fail-error
Dec 5, 2017
Merged

output unmount error when unmount fail in diff.Apply#1877
crosbymichael merged 1 commit intocontainerd:masterfrom
yanxuean:add-unmount-fail-error

Conversation

@yanxuean
Copy link
Copy Markdown
Member

@yanxuean yanxuean commented Dec 5, 2017

Signed-off-by: yason [email protected]

When unmount fail we should output unmount err and return error.

@dmcgowan dmcgowan added this to the 1.0.0 milestone Dec 5, 2017
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Dec 5, 2017

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files          86       86           
  Lines        8332     8332           
=======================================
  Hits         4072     4072           
  Misses       3586     3586           
  Partials      674      674
Flag Coverage Δ
#linux 52.34% <ø> (ø) ⬆️
#windows 44.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77fa49...147d498. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit a9caf9b into containerd:master Dec 5, 2017
@yanxuean yanxuean deleted the add-unmount-fail-error branch December 5, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants