filters: supporting alternative characters for quote#1874
Merged
stevvooe merged 1 commit intocontainerd:masterfrom Dec 5, 2017
Merged
filters: supporting alternative characters for quote#1874stevvooe merged 1 commit intocontainerd:masterfrom
stevvooe merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
- Coverage 49.14% 48.65% -0.49%
==========================================
Files 86 87 +1
Lines 8389 8568 +179
==========================================
+ Hits 4123 4169 +46
- Misses 3591 3714 +123
- Partials 675 685 +10
Continue to review full report at Codecov.
|
Member
|
LGTM |
The regexp syntax can have some nasty characters to handle quoting correctly, in practice. In certain scenarios a double quote works well, but it can affect readability for certain regexps. This introduces a quoting mode that treats `/` and `|` as a double quote to make the quoting in regular expressions more familiar and readable. This change is introduced in a backwards compatible manner, so existing regexp quoting is not affected. Signed-off-by: Stephen J Day <[email protected]>
stevvooe
force-pushed
the
regexp-quoting-syntax
branch
from
3960d6a to
4dfcf60
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regexp syntax can have some nasty characters to handle quoting
correctly, in practice. In certain scenarios a double quote works well,
but it can affect readability for certain regexps. This introduces a
quoting mode that treats
/and|as a double quote to make thequoting in regular expressions more familiar and readable.
This change is introduced in a backwards compatible manner, so existing
regexp quoting is not affected.
Closes #1233
Signed-off-by: Stephen J Day [email protected]