Add more descriptive error on manifest list push#1872
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Dec 5, 2017
Merged
Add more descriptive error on manifest list push#1872dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
stevvooe
reviewed
Dec 4, 2017
stevvooe
approved these changes
Dec 4, 2017
Adds a more descriptive error message for pushing indexes/manifest list references with missing content references to a docker v2 API supporting container registry. This can be followed up with a more complete review of how to handle "deep" references for manifest lists on push/pull post containerd 1.0. Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
manifest-list-push
branch
from
e90b1e6 to
02661c7
Compare
Member
Author
|
addded the |
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 86 86
Lines 8263 8263
=======================================
Hits 4055 4055
Misses 3538 3538
Partials 670 670
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a more descriptive error message for pushing indexes/manifest list
references with missing content references to a docker v2 API supporting
container registry. This can be followed up with a more complete review
of how to handle "deep" references for manifest lists on push/pull post
containerd 1.0.
Signed-off-by: Phil Estes [email protected]
Reference: #1772