docs: fix usage of cio package in docs#1869
Merged
stevvooe merged 1 commit intocontainerd:masterfrom Dec 4, 2017
Merged
Conversation
Signed-off-by: Ace-Tang <[email protected]>
dnephin
reviewed
Dec 4, 2017
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Thanks, I must have missed a few of these
ijc
reviewed
Dec 4, 2017
| ```go | ||
| // create a new task | ||
| task, err := redis.NewTask(context, containerd.Stdio) | ||
| task, err := redis.NewTask(context, cio.Stdio) |
Contributor
There was a problem hiding this comment.
When containerd.Client is introduced further up this file a import "github.com/containerd/containerd" is included to give the context. Do we want/need a similar import "github.com/containerd/containerd/cio" to give context for the use of cio.Stdio?
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
=======================================
Coverage 49.18% 49.18%
=======================================
Files 86 86
Lines 8244 8244
=======================================
Hits 4055 4055
Misses 3519 3519
Partials 670 670
Continue to review full report at Codecov.
|
Member
|
LGTM We'll take care of the feedback in a follow up. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update docs