get wrong parents bucket in withSnapshotBucket#1864
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Dec 4, 2017
Merged
get wrong parents bucket in withSnapshotBucket#1864crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
=======================================
Coverage 49.18% 49.18%
=======================================
Files 86 86
Lines 8244 8244
=======================================
Hits 4055 4055
Misses 3519 3519
Partials 670 670
Continue to review full report at Codecov.
|
improve error message for CommitActive Signed-off-by: yason <[email protected]>
yanxuean
force-pushed
the
withSnapshotBucket
branch
from
91620e5 to
db742c9
Compare
Closed
dnephin
reviewed
Dec 4, 2017
| spbkt := bkt.Bucket([]byte(si.Parent)) | ||
| if spbkt == nil { | ||
| return errors.Wrap(errdefs.ErrNotFound, "missing parent") | ||
| return errors.Wrapf(errdefs.ErrNotFound, "missing parent snapshot of %q", key) |
Contributor
There was a problem hiding this comment.
I think it would be good to include si.Parent in the error message as well: "missing parent %q of snapshot %s", si.Parent, key
| // Updates parent back link to use new key | ||
| if err := pbkt.Put(parentKey(pid, id), []byte(name)); err != nil { | ||
| return errors.Wrap(err, "failed to update parent link") | ||
| return errors.Wrapf(err, "failed to update parent link from %q to %q", key, name) |
Contributor
There was a problem hiding this comment.
Isn't the previous parent id pid not key ? So the message should be something like: "failed to update parent link of %q to %q", key, name ?
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yason [email protected]
Closes #1851