Skip to content

integration: ignore not found error on cleanup#1860

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
stevvooe:ignore-not-found
Dec 1, 2017
Merged

integration: ignore not found error on cleanup#1860
crosbymichael merged 1 commit intocontainerd:masterfrom
stevvooe:ignore-not-found

Conversation

@stevvooe
Copy link
Copy Markdown
Member

@stevvooe stevvooe commented Dec 1, 2017

This ignore "not found" errors that may arise during test cleanup. Since
the goal is to make the content "not found", it is okay to skip them and
not fail the test.

Signed-off-by: Stephen J Day [email protected]

Closes #1823

This ignore "not found" errors that may arise during test cleanup. Since
the goal is to make the content "not found", it is okay to skip them and
not fail the test.

Signed-off-by: Stephen J Day <[email protected]>
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1860 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   49.18%   49.18%           
=======================================
  Files          86       86           
  Lines        8244     8244           
=======================================
  Hits         4055     4055           
  Misses       3519     3519           
  Partials      670      670
Flag Coverage Δ
#linux 52.6% <ø> (ø) ⬆️
#windows 44.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271836a...0925a88. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 9657239 into containerd:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants