Skip to content

Update snapshot and content related log messages#1859

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-snapshot-logs
Dec 2, 2017
Merged

Update snapshot and content related log messages#1859
stevvooe merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-snapshot-logs

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Dec 1, 2017

Make the tense and casing consistent. Add useful log messages in image service.

Make the tense and casing consistent.
Add useful log messages in image service.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan mentioned this pull request Dec 1, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1859 into master will not change coverage.
The diff coverage is 16%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1859   +/-   ##
=======================================
  Coverage   49.18%   49.18%           
=======================================
  Files          86       86           
  Lines        8244     8244           
=======================================
  Hits         4055     4055           
  Misses       3519     3519           
  Partials      670      670
Flag Coverage Δ
#linux 52.6% <16%> (ø) ⬆️
#windows 44.25% <33.33%> (ø) ⬆️
Impacted Files Coverage Δ
metadata/snapshot.go 45.95% <0%> (ø) ⬆️
snapshots/btrfs/btrfs.go 56.06% <0%> (ø) ⬆️
snapshots/overlay/overlay.go 56.13% <0%> (ø) ⬆️
snapshots/naive/naive.go 43.89% <0%> (ø) ⬆️
metadata/gc.go 61.67% <100%> (ø) ⬆️
metadata/db.go 66.93% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271836a...b28d7cd. Read the comment docs.

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Dec 2, 2017

LGTM

@stevvooe stevvooe merged commit fe4e30c into containerd:master Dec 2, 2017
@dmcgowan dmcgowan deleted the fix-snapshot-logs branch September 10, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants