update image error messages#1858
Conversation
Signed-off-by: Jess Valarezo <[email protected]>
|
Looks like there is some extra stuff in |
|
LGTM |
|
|
||
| } | ||
| return nil, errors.Wrap(errdefs.ErrNotFound, "could not resolve manifest") | ||
| return nil, errors.Wrapf(errdefs.ErrNotFound, "could not resolve manifest %v", desc.Digest) |
There was a problem hiding this comment.
Isn't this case something like "unexpected media type %s for %s", desc.MediaType, desc.Digest ?
I'm not sure why this is "not found"
There was a problem hiding this comment.
The class of error is that the manifest is not found. It could not be found because it was unresolvable.
There was a problem hiding this comment.
Not found is the correct class, but we could add the media type here to make it clearer why the resolution couldn't happen
There was a problem hiding this comment.
Ok, take care of this in a follow up.
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 44.25% 49.18% +4.93%
==========================================
Files 67 86 +19
Lines 7105 8244 +1139
==========================================
+ Hits 3144 4055 +911
- Misses 3468 3519 +51
- Partials 493 670 +177
Continue to review full report at Codecov.
|
|
LGTM @jessvalarezo Looks like the stuff in #1858 (comment) was already there, so let's handle it in another PR. |
5 participants
#1855 shows an unclear error message
becomes
Signed-off-by: Jess Valarezo [email protected]