Skip to content

vendor: update ttrpc to pull in euid change#1855

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
stevvooe:update-ttrpc
Dec 1, 2017
Merged

vendor: update ttrpc to pull in euid change#1855
dmcgowan merged 1 commit intocontainerd:masterfrom
stevvooe:update-ttrpc

Conversation

@stevvooe
Copy link
Copy Markdown
Member

@stevvooe stevvooe commented Dec 1, 2017

Signed-off-by: Stephen J Day [email protected]

@stevvooe stevvooe added this to the 1.0.0 milestone Dec 1, 2017
@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 1, 2017

Flaky test? Looks like another error message ripe for improvement!

--- FAIL: TestShimSigkilled (0.60s)
	container_linux_test.go:741: : manifest not found: not found

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Dec 1, 2017

Another flaky test in another PR

    --- FAIL: TestContentClient/Resume (0.02s)
    	testsuite.go:183: compare update 2017-12-01 20:42:19.313214335 +0000 UTC against (2017-12-01 20:42:19.313039486 +0000 UTC m=+5.196404615, 2017-12-01 20:42:19.313433172 +0000 UTC m=+5.196798300)
    	testsuite.go:192: compare update 2017-12-01 20:42:19.313214335 +0000 UTC against (2017-12-01 20:42:19.313039486 +0000 UTC m=+5.196404615, 2017-12-01 20:42:19.313433172 +0000 UTC m=+5.196798300)
    	testsuite.go:200: compare update 2017-12-01 20:42:19.321282581 +0000 UTC against (2017-12-01 20:42:19.321138715 +0000 UTC m=+5.204503849, 2017-12-01 20:42:19.321502922 +0000 UTC m=+5.204868043)
    	helpers.go:52: drwx------       4096 /tmp/content-suite-ContentClient-628822724
    	testsuite.go:46: Cleanup failed: not found

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Dec 1, 2017

@estesp Looks like a bad redis version was pushed to the hub:

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1571,
         "digest": "sha256:420ae0e3bb344f8a8d2059f6286dfcb9328e65b9e1e0f7f359f1ac5d8ae6f9c6",
         "platform": {
            "architecture": "arm64",
            "os": "linux",
            "variant": "v8"
         }
      }
   ]
}

That is failing consistently.

@crosbymichael That one is definitely flaky.

@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 1, 2017

painful timing, but yes: redis/docker-library-redis#115

Forgot that was our test image. It will automatically resolve once the amd64 builder is done and the manifest list is repushed with more architectures.

@jessvalarezo jessvalarezo mentioned this pull request Dec 1, 2017
Merged
@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Dec 1, 2017

Also, I forgot to mention this will get us a 5x performance improvement in the shim ttrpc requests...

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1855 into master will increase coverage by 4.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
+ Coverage   44.25%   49.18%   +4.93%     
==========================================
  Files          67       86      +19     
  Lines        7105     8244    +1139     
==========================================
+ Hits         3144     4055     +911     
- Misses       3468     3519      +51     
- Partials      493      670     +177
Flag Coverage Δ
#linux 52.6% <ø> (?)
#windows 44.25% <ø> (ø) ⬆️
Impacted Files Coverage Δ
archive/tar_unix.go 50.81% <0%> (ø)
fs/hardlink_unix.go 60% <0%> (ø)
content/local/store_unix.go 80% <0%> (ø)
oci/spec.go 50% <0%> (ø)
mount/mount_linux.go 0% <0%> (ø)
mount/lookup_unix.go 0% <0%> (ø)
oci/spec_unix.go 98.37% <0%> (ø)
mount/mountinfo_linux.go 55% <0%> (ø)
oci/spec_opts_unix.go 5.9% <0%> (ø)
oci/spec_opts.go 0% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222156d...4b36430. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Dec 1, 2017

LGTM

1 similar comment
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Dec 1, 2017

LGTM

@dmcgowan dmcgowan merged commit 8c55085 into containerd:master Dec 1, 2017
@stevvooe stevvooe deleted the update-ttrpc branch December 1, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stevvooe @estesp @crosbymichael @codecov-io @dmcgowan