Skip to content

improve error message#1852

Merged
estesp merged 1 commit intocontainerd:masterfrom
yanxuean:error-log
Dec 1, 2017
Merged

improve error message#1852
estesp merged 1 commit intocontainerd:masterfrom
yanxuean:error-log

Conversation

@yanxuean
Copy link
Copy Markdown
Member

@yanxuean yanxuean commented Dec 1, 2017

Signed-off-by: yason [email protected]
The two error message are same.

func (s *snapshotter) Commit(ctx context.Context, name, key string, opts ...snapshots.Opt) error {
        return update(ctx, s.db, func(tx *bolt.Tx) error {
		bkt := getSnapshotterBucket(tx, ns, s.name)
		if bkt == nil {
			return errors.Wrapf(errdefs.ErrNotFound, "snapshot %v does not exist", key)
		}
                ......
                obkt := bkt.Bucket([]byte(key))
		if obkt == nil {
			return errors.Wrapf(errdefs.ErrNotFound, "snapshot %v does not exist", key)
		}

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1852 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   49.13%   49.12%   -0.01%     
==========================================
  Files          86       86              
  Lines        8245     8246       +1     
==========================================
  Hits         4051     4051              
- Misses       3524     3525       +1     
  Partials      670      670
Flag Coverage Δ
#linux 52.52% <0%> (-0.01%) ⬇️
#windows 44.25% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
metadata/snapshot.go 45.95% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c36d4...4f1c0e0. Read the comment docs.

@yanxuean yanxuean mentioned this pull request Dec 1, 2017
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 16a2177 into containerd:master Dec 1, 2017
@yanxuean yanxuean deleted the error-log branch December 1, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants