LGTM

@mlaventure There is a problem with the darwin build. It gets folded into "unix", but doesn't implement unix.Ucred, unix.GetsockoptUcred and unix.SO_PEERCRED. Pushing a fix to exclude these from the "darwin shim", which isn't really supported, but we build anyways.

Fixing now.

user.Current segfaults when statically build, due to a glibc issue that won't be fixed: moby/moby#29478

So I suggest using getuid syscall.

Oh, that's a nasty one 😱

p.s. As described in golang/go#13470 (comment), the segfault issue does not happen when only single goroutine is running.
So the issue might not be critical for our shim, but we should not rely on the number of goroutines, I think.

user.Current segfaults when statically build, due to a glibc issue that won't be fixed

Seems to run just fine. What version is affected? I am running glibc 2.24 locally but it seems 2.21 is affected.

Tried the example in golang/go#13470. The compiler seems to complain:

$ gcc -static -pthread -o cboom f.c
/tmp/ccZURPLs.o: In function `thread':
f.c:(.text+0x53): warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

While that is a warning and not a compile error is insane. How can this be called statically linked if it requires the shared library? Madness.

Filed containerd/ttrpc#13.

Updated, PTAL.

opened containerd/ttrpc#14

Codecov Report

Merging #1849 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1849   +/-   ##
=======================================
  Coverage   49.13%   49.13%           
=======================================
  Files          86       86           
  Lines        8245     8245           
=======================================
  Hits         4051     4051           
  Misses       3524     3524           
  Partials      670      670

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe9e28...2d966df. Read the comment docs.

Filed golang/go#22953