metadata: update container error messages#1847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 86 86
Lines 8246 8246
=======================================
Hits 4051 4051
Misses 3525 3525
Partials 670 670
Continue to review full report at Codecov.
|
jessvalarezo
force-pushed
the
metadata-errors
branch
from
3e20805 to
c849f55
Compare
|
LGTM |
There was a problem hiding this comment.
within all the validation packages errors are wrapped with errdefs.ErrInvalidArgument and whenever validateContainer is called the err message includes "... failed validation". thought this would help avoid redundancy.
There was a problem hiding this comment.
I prefer to no "from bucket". The user don't know bucket.
There was a problem hiding this comment.
- duplicated "id"
- namespace and bucket is unnecessary
There was a problem hiding this comment.
leaving in namespace since it's helpful for the user
Signed-off-by: Jess Valarezo <[email protected]>
jessvalarezo
force-pushed
the
metadata-errors
branch
from
c849f55 to
b873ae8
Compare
|
LGTM |
5 participants
Part of an effort to make error messages consistent and as helpful as possible. Very open to any suggestions!!
Signed-off-by: Jess Valarezo [email protected]