Skip to content

Conversation

@crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby [email protected]

Signed-off-by: Michael Crosby <[email protected]>
@Random-Liu
Copy link
Member

The unit file we use for docker has this set, too.

[Unit]
Description=Docker Application Container Engine
Documentation=https://docs.docker.com
After=network.target docker.socket
Requires=docker.socket

[Service]
Type=notify
EnvironmentFile=-/etc/default/docker
# the default is not to use systemd for cgroups because the delegate issues still
# exists and systemd currently does not support the cgroup feature set required
# for containers run by docker
ExecStartPre=/bin/sh -x -c "if [ ! -s /var/lib/docker/repositories-overlay ]; then rm -f /var/lib/docker/repositories-overlay; fi"
ExecStart=/usr/bin/dockerd -s overlay --registry-mirror=https://mirror.gcr.io --host=fd:// $DOCKER_OPTS
ExecReload=/bin/kill -s HUP $MAINPID
ExecStopPost=/bin/echo "docker daemon exited"
LimitNOFILE=1048576
# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNPROC=infinity
LimitCORE=infinity
# Uncomment TasksMax if your systemd version supports it.
# Only systemd 226 and above support this version.
#TasksMax=infinity
TimeoutStartSec=0
# set delegate yes so that systemd does not reset the cgroups of docker containers
Delegate=yes
# kill only the docker process, not all processes in the cgroup
KillMode=process

[Install]
WantedBy=multi-user.target

Will do it for containerd.

@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1846 into master will decrease coverage by 3.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1846      +/-   ##
==========================================
- Coverage   52.53%   49.13%   -3.41%     
==========================================
  Files          78       86       +8     
  Lines        6683     8245    +1562     
==========================================
+ Hits         3511     4051     +540     
- Misses       2505     3524    +1019     
- Partials      667      670       +3
Flag Coverage Δ
#linux 52.53% <ø> (ø) ⬆️
#windows 44.25% <ø> (?)
Impacted Files Coverage Δ
fs/path.go 61.69% <0%> (-12.84%) ⬇️
snapshots/naive/naive.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 46.04% <0%> (-9%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
remotes/docker/fetcher.go 41.42% <0%> (-7.6%) ⬇️
fs/copy.go 34.83% <0%> (-7.2%) ⬇️
metadata/containers.go 47.31% <0%> (-6.4%) ⬇️
content/local/writer.go 50% <0%> (-6.17%) ⬇️
metadata/buckets.go 56% <0%> (-6.13%) ⬇️
archive/tar.go 43.47% <0%> (-5.86%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4be46...b009642. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevvooe
Copy link
Member

stevvooe commented Dec 1, 2017

LGTM

I'll let @crosbymichael decide if he wants to add the suggestions from @Random-Liu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants