Change default subreaper setting#1822
Merged
mlaventure merged 1 commit intocontainerd:masterfrom Nov 28, 2017
Merged
Conversation
This subreaper should always be turned on for containerd unless explicitly needed for it to be off. Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 49.39% 49.39%
=======================================
Files 82 82
Lines 8362 8362
=======================================
Hits 4130 4130
Misses 3573 3573
Partials 659 659
Continue to review full report at Codecov.
|
mlaventure
approved these changes
Nov 28, 2017
Contributor
mlaventure
left a comment
mlaventure
left a comment
There was a problem hiding this comment.
LGTM
Should not forget to add this to the release notes though
Member
|
@mlaventure said:
Oops :( |
Contributor
|
😂, I guess we should add labels for that |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This subreaper should always be turned on for containerd unless
explicitly needed for it to be off.
Signed-off-by: Michael Crosby [email protected]