Skip to content

Revendor hcsshim and go-tar#1812

Merged
crosbymichael merged 3 commits intocontainerd:masterfrom
darstahl:revendor
Nov 29, 2017
Merged

Revendor hcsshim and go-tar#1812
crosbymichael merged 3 commits intocontainerd:masterfrom
darstahl:revendor

Conversation

@darstahl
Copy link
Copy Markdown
Contributor

@darstahl darstahl commented Nov 27, 2017

Update hcsshim to take some fixes including one for Go1.9

Update go-tar to use the go1.10 fork in order to prepare for the Windows Archiver.

Signed-off-by: Darren Stahl [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 27, 2017 •
edited
Loading

Codecov Report

Merging #1812 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1812      +/-   ##
==========================================
- Coverage   49.23%   49.17%   -0.06%     
==========================================
  Files          84       86       +2     
  Lines        8442     8518      +76     
==========================================
+ Hits         4156     4189      +33     
- Misses       3619     3659      +40     
- Partials      667      670       +3
Flag Coverage Δ
#linux 49.27% <0%> (-0.02%) ⬇️
#windows 44.25% <0%> (-1.47%) ⬇️
Impacted Files Coverage Δ
archive/tar.go 47.05% <0%> (-0.25%) ⬇️
archive/time_windows.go 60% <0%> (ø)
archive/tar_windows.go 40.67% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a6b79...bc9cb25. Read the comment docs.

@darstahl
Copy link
Copy Markdown
Contributor Author

darstahl commented Nov 28, 2017

/cc @dmcgowan

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Nov 28, 2017

LGTM

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Nov 28, 2017

Please rebase.

@darstahl @dmcgowan
Revendor hcsshim and go-tar
444e422 
Signed-off-by: Darren Stahl <[email protected]>
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Nov 29, 2017

Need to figure this one out hdr.Xattrs is deprecated: Use PAXRecords instead

@darstahl
Copy link
Copy Markdown
Contributor Author

darstahl commented Nov 29, 2017

The changes added for XAttrs/PAXHeaders LGTM

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Nov 29, 2017

LGTM

@crosbymichael crosbymichael merged commit a56e742 into containerd:master Nov 29, 2017
@kolyshkin
Copy link
Copy Markdown
Contributor

kolyshkin commented Dec 8, 2017

This one introduces a regression, as go-tar from go-1.10 now uses user.LookupId() etc., which leads to the following ugly but rightful errors when compiling static binaries:

/tmp/go-link-408986199/000003.o: In function `mygetgrouplist':
/usr/lib/go-1.9/src/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-408986199/000003.o: In function `mygetgrgid_r':
/usr/lib/go-1.9/src/os/user/cgo_lookup_unix.go:38: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-408986199/000003.o: In function `mygetgrnam_r':
/usr/lib/go-1.9/src/os/user/cgo_lookup_unix.go:43: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-408986199/000003.o: In function `mygetpwnam_r':
/usr/lib/go-1.9/src/os/user/cgo_lookup_unix.go:33: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-408986199/000003.o: In function `mygetpwuid_r':
/usr/lib/go-1.9/src/os/user/cgo_lookup_unix.go:28: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

I'm not quite sure what to do about it yet.

This was referenced Aug 7, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@darstahl @codecov-io @stevvooe @dmcgowan @crosbymichael @kolyshkin