Skip to content

DOCS ONLY: dest vs dst typo in ctr help output#1593

Closed
metahertz wants to merge 1 commit intocontainerd:masterfrom
metahertz:ctr-docs-typo
Closed

DOCS ONLY: dest vs dst typo in ctr help output#1593
metahertz wants to merge 1 commit intocontainerd:masterfrom
metahertz:ctr-docs-typo

Conversation

@metahertz
Copy link
Copy Markdown

dest is not valid for --mount options, correct usage is dst=/path.

@crosbymichael
Copy link
Copy Markdown
Member

@matjohn2 thanks for the PR.

You will need to sign your commit with a valid DCO.

You can read more about what it is, what it means, and how to do it here: https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Oct 9, 2017

Closing without the DCO. If you want to update, please update the branch and ping us so we can re-open and merge.

@stevvooe stevvooe closed this Oct 9, 2017
@metahertz
Copy link
Copy Markdown
Author

@stevvooe Branch updated, sorry for the mess-around.

@stevvooe
Copy link
Copy Markdown
Member

@matjohn2 Thank you so much!

Unfortunately, it won't let me re-open this PR after the force-push, so you will need to open a new PR.

I'm so sorry about the runaround. We do really appreciate changes like this!

@metahertz
Copy link
Copy Markdown
Author

Thats what i get for trying to be clever with a --ammend for adding the DCO! </lesson_learnt>
No worries at all, #1623

dmcgowan pushed a commit to dmcgowan/containerd that referenced this pull request Oct 7, 2020
Add missing sandbox labels when invoking nri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants