Codecov Report

Merging #1584 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files          26       26           
  Lines        3542     3542           
=======================================
  Hits         1645     1645           
  Misses       1519     1519           
  Partials      378      378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8426ed...d7c4611. Read the comment docs.

Thank you for PR, please add UT?

@miaoyq Thanks for fixing this!

LGTM

If you have time can you write a quick unit test for this?

We already have mountinfo output as a const in the tests files that you could use for parsing and output:

https://github.com/containerd/containerd/blob/master/mount/mountinfo_linux_test.go#L11

I think it's national holiday in China this week, let's give @miaoyq some time. :)

If you have time can you write a quick unit test for this?
We already have mountinfo output as a const in the tests files that you could use for parsing and output:
https://github.com/containerd/containerd/blob/master/mount/mountinfo_linux_test.go#L11

@crosbymichael I'm sorry for delay, I have tried to test this with the const, but seems not feasible, because mountinfo in Lookup() is get from /proc/self/mountinfo by Self().

I think maybe we could add unit test for this in testLookup.

I think it's national holiday in China this week, let's give @miaoyq some time. :)

@Random-Liu Thanks for your understanding. 🙂

@miaoyq ya, we can breakout the logic into an internal func that takes a io.Reader so that it can be unit tested.

func Lookup() {
f, err := os.Open("/proc/sefl/mountinfo")
    lookupMounts(f)
}

@crosbymichael Seems to still can not add unit test for this，because dir must be a real directory in host， we need to get the syscall.Stat_t of dir through syscall.Stat(), info.MountPoint also.

@crosbymichael I have added unit test for this in testLookup.

LGTM

ping @mlaventure