remove field defaultns from struct Client#1571
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Sep 28, 2017
Merged
Conversation
Member
|
You need to gofmt your code |
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
remove-defaultns-from-Client
branch
from
888b321 to
fd44a3a
Compare
Contributor
Author
|
Thanks for your feedback. @crosbymichael |
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 42.36% 42.36%
=======================================
Files 24 24
Lines 3368 3368
=======================================
Hits 1427 1427
Misses 1612 1612
Partials 329 329Continue to review full report at Codecov.
|
Member
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
…-link README: Update slack reference to CNCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that we did not use
defaultnsin Client struct. So I try to remove this.And feel free to correct me if i was wrong.
Signed-off-by: Allen Sun [email protected]