Skip to content

readonly: pass RW rootfs to runtime, and let the runtime remount it as RO#1570

Merged
mlaventure merged 1 commit intocontainerd:masterfrom
AkihiroSuda:oci-runtime-readonly
Sep 29, 2017
Merged

readonly: pass RW rootfs to runtime, and let the runtime remount it as RO#1570
mlaventure merged 1 commit intocontainerd:masterfrom
AkihiroSuda:oci-runtime-readonly

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Sep 28, 2017

This allows the runtime to creating extra mount points before remounting the rootfs as read-only.

Fix #1495

cc @Random-Liu @crosbymichael @dmcgowan @stevvooe

Signed-off-by: Akihiro Suda [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 28, 2017 •
edited
Loading

Codecov Report

Merging #1570 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1570   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files          24       24           
  Lines        3368     3368           
=======================================
  Hits         1427     1427           
  Misses       1612     1612           
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b353d...27023c7. Read the comment docs.

crosbymichael
crosbymichael reviewed Sep 28, 2017
View reviewed changes
Comment thread spec_opts_unix.go Outdated
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael Sep 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to take a bool, it should just set the root as readonly.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Sep 29, 2017

updated PR @crosbymichael

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Sep 29, 2017

LGTM

@crosbymichael crosbymichael mentioned this pull request Sep 29, 2017
Closed
mlaventure
mlaventure approved these changes Sep 29, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 16bf823 into containerd:master Sep 29, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
@mikebrow
Merge pull request containerd#1570 from yoheiueda/masked
b1ee4c0 
Set masked and readonly paths based on default Unix spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael left review comments

@mlaventure mlaventure mlaventure approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkihiroSuda @codecov-io @crosbymichael @mlaventure