client: Prevent Out-Of-Range panic in task.Metrics()#1559
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 26, 2017
Merged
client: Prevent Out-Of-Range panic in task.Metrics()#1559estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
Member
|
is this caused by a race? |
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
=======================================
Coverage 42.36% 42.36%
=======================================
Files 24 24
Lines 3368 3368
=======================================
Hits 1427 1427
Misses 1612 1612
Partials 329 329Continue to review full report at Codecov.
|
Contributor
Author
|
Yes, Docker regularly calls the metric endpoint from a separate go routine.
On Mon, Sep 25, 2017, 4:00 PM Michael Crosby ***@***.***> wrote:
is this caused by a race?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1559 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APUifkYQXFNJTG7se4VSGJ1wNf3foUsjks5smDB4gaJpZM4PjcXr>
.
--
Sent from my phone.
|
Member
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]