Skip to content

Move unix specific tidbits into dialer_unix.go#1558

Merged
estesp merged 1 commit intocontainerd:masterfrom
mlaventure:dialer-quick-fix
Sep 25, 2017
Merged

Move unix specific tidbits into dialer_unix.go#1558
estesp merged 1 commit intocontainerd:masterfrom
mlaventure:dialer-quick-fix

Conversation

@mlaventure
Copy link
Copy Markdown
Contributor

Signed-off-by: Kenfe-Mickael Laventure [email protected]

Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1558   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files          24       24           
  Lines        3368     3368           
=======================================
  Hits         1427     1427           
  Misses       1612     1612           
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76bfff3...c42f56b. Read the comment docs.

@estesp estesp merged commit 1a9d939 into containerd:master Sep 25, 2017
@mlaventure mlaventure deleted the dialer-quick-fix branch September 25, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants