Skip to content

State adding tests when submitting changes#1556

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:tests
Sep 25, 2017
Merged

State adding tests when submitting changes#1556
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:tests

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This is a priority that tests are added for regressions and new
functionality.

Signed-off-by: Michael Crosby [email protected]

This is a priority that tests are added for regressions and new
functionality.

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1556   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files          24       24           
  Lines        3368     3368           
=======================================
  Hits         1427     1427           
  Misses       1612     1612           
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76bfff3...76a2d1c. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan merged commit 357eff8 into containerd:master Sep 25, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants