Update client to pass go lint#1555
Conversation
There was a problem hiding this comment.
It's technically a named pipe on windows. Maybe use local transport ?
There was a problem hiding this comment.
not in this method, look at the code
There was a problem hiding this comment.
Hum, I see.
address = strings.TrimPrefix(address, "unix://")Should be moved into dialer() version of unix actually. Dialer() is used by all platforms.
There was a problem hiding this comment.
idk, maybe in another PR for the windows work
There was a problem hiding this comment.
with #1558 basically ready to merge do you want to clarify the comment or handle via a follow-up PR @crosbymichael?
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=======================================
Coverage 42.36% 42.36%
=======================================
Files 24 24
Lines 3368 3368
=======================================
Hits 1427 1427
Misses 1612 1612
Partials 329 329Continue to review full report at Codecov.
|
|
LGTM |
There is one breaking change with the function naming of UidGid to UIDGID Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
client-lint
branch
from
899799a to
51b9240
Compare
|
@mlaventure @estesp updated |
Bump Golang 1.13.15
5 participants
There is one breaking change with the function naming of UidGid to
UIDGID
Signed-off-by: Michael Crosby [email protected]