Skip to content

update docs and comments#1552

Merged
estesp merged 1 commit intocontainerd:masterfrom
allencloud:update-docs-and-comments
Sep 25, 2017
Merged

update docs and comments#1552
estesp merged 1 commit intocontainerd:masterfrom
allencloud:update-docs-and-comments

Conversation

@allencloud
Copy link
Copy Markdown
Contributor

@allencloud allencloud commented Sep 25, 2017

When I read the docs about containerd, I found that some nit via reading or IDE.

So I update docs and comments.

Signed-off-by: Allen Sun [email protected]

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Sep 25, 2017

CI failing

0.08s$ GIT_CHECK_EXCLUDE="./vendor" TRAVIS_COMMIT_RANGE="${TRAVIS_COMMIT_RANGE/.../..}" make dco
git-validation -q -run DCO,short-subject,dangling-whitespace
 0fdf030 - FAIL - has whitespace errors. See `git show --check 0fdf030447098f12e6523d9c91e1a8fbcab3d7d3`.
1 commits to fix
make: *** [dco] Error 1

@allencloud allencloud force-pushed the update-docs-and-comments branch from 0fdf030 to 3c3cd21 Compare September 25, 2017 03:46
@allencloud
Copy link
Copy Markdown
Contributor Author

allencloud commented Sep 25, 2017

Oh, Thanks a lot for your remind. I noticed that in the original file there are some more whitespaces there. PTAL @AkihiroSuda

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 25, 2017 •
edited
Loading

Codecov Report

Merging #1552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1552   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files          24       24           
  Lines        3368     3368           
=======================================
  Hits         1427     1427           
  Misses       1612     1612           
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c6211...4700968. Read the comment docs.

AkihiroSuda
AkihiroSuda approved these changes Sep 25, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud
update docs and comments
4700968 
Signed-off-by: Allen Sun <[email protected]>
@allencloud allencloud force-pushed the update-docs-and-comments branch from 3c3cd21 to 4700968 Compare September 25, 2017 06:49
estesp
estesp approved these changes Sep 25, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 8e44719 into containerd:master Sep 25, 2017
@allencloud allencloud deleted the update-docs-and-comments branch September 25, 2017 14:20
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
@dmcgowan
Merge pull request containerd#1552 from crosbymichael/nri
56a89cd 
Add experimental NRI injection points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allencloud @AkihiroSuda @codecov-io @estesp