Skip to content

design: remove distribution GRPC service#1547

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
AkihiroSuda:remove-dist-grpc
Sep 22, 2017
Merged

design: remove distribution GRPC service#1547
crosbymichael merged 1 commit intocontainerd:masterfrom
AkihiroSuda:remove-dist-grpc

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Signed-off-by: Akihiro Suda [email protected]

@stevvooe
Copy link
Copy Markdown
Member

@crosbymichael Should we update our design docs or should we preserve these and document what we did?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1547 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1547   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files          24       24           
  Lines        3368     3368           
=======================================
  Hits         1427     1427           
  Misses       1612     1612           
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df896c9...3a88be3. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

@stevvooe update?maybe???

@stevvooe
Copy link
Copy Markdown
Member

@crosbymichael Ok, we can take that on as a post-1.0 task.

@stevvooe
Copy link
Copy Markdown
Member

LGTM

Filed #1548 to capture the larger body of work.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 9a7e776 into containerd:master Sep 22, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
…d-should-search

adds support for pod id lookup for filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants