Skip to content

Fix container CreatedAt and UpdatedAt.#1543

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-container-timestamp
Sep 22, 2017
Merged

Fix container CreatedAt and UpdatedAt.#1543
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-container-timestamp

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Sep 22, 2017

Currently container CreatedAt and UpdatedAt are not properly exposed:

    "CreatedAt": "0001-01-01T00:00:00Z",
    "UpdatedAt": "0001-01-01T00:00:00Z",

This PR fixes it:

    "CreatedAt": "2017-09-22T05:54:41.351119711Z",
    "UpdatedAt": "2017-09-22T05:54:41.351119711Z",

Signed-off-by: Lantao Liu [email protected]

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   42.61%   42.61%           
=======================================
  Files          24       24           
  Lines        3318     3318           
=======================================
  Hits         1414     1414           
  Misses       1581     1581           
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709d34f...5452112. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 94b5aaf into containerd:master Sep 22, 2017
@Random-Liu Random-Liu deleted the fix-container-timestamp branch September 22, 2017 17:30
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Allow GC to discard content after successful pull and unpack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants