Skip to content

Add v1 to metrics API endpoint#1534

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:metricsv1
Sep 21, 2017
Merged

Add v1 to metrics API endpoint#1534
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:metricsv1

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Fixes #1399

This versions the prometheus metrics API so we can manage backwards
incompatible changes in the future more easily.

Signed-off-by: Michael Crosby [email protected]

Fixes containerd#1399

This versions the prometheus metrics API so we can manage backwards
incompatible changes in the future more easily.

Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1534   +/-   ##
=======================================
  Coverage   42.61%   42.61%           
=======================================
  Files          24       24           
  Lines        3318     3318           
=======================================
  Hits         1414     1414           
  Misses       1581     1581           
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9934acb...f23edd3. Read the comment docs.

@crosbymichael crosbymichael added this to the containerd 1.0.0 milestone Sep 21, 2017
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dqminh
Copy link
Copy Markdown
Member

dqminh commented Sep 21, 2017

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 2146fee into containerd:master Sep 21, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Update selinux pkg and allow category range to be set in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants