fixes missing default permission#1532
fixes missing default permission#1532estesp merged 1 commit intocontainerd:masterfrom mikebrow:seccomp-default-proc-fix
Conversation
Signed-off-by: Mike Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1532 +/- ##
=======================================
Coverage 42.61% 42.61%
=======================================
Files 24 24
Lines 3318 3318
=======================================
Hits 1414 1414
Misses 1581 1581
Partials 323 323Continue to review full report at Codecov.
|
| Args: []specs.LinuxSeccompArg{}, | ||
| }) | ||
| case "amd", "x32": | ||
| case "amd64": |
There was a problem hiding this comment.
the syscall is only available on 64-bit (https://www.systutorials.com/docs/linux/man/2-arch_prctl/) so I assume the x32 was an error anyway.
There was a problem hiding this comment.
from my digging around does not exist as a valid golang runtime.GOARCH response..
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
Not sure about the "386" (see comment); the other change appears to be correct from what I understand.
| Args: []specs.LinuxSeccompArg{}, | ||
| }) | ||
| case "amd", "x32": | ||
| case "amd64": |
There was a problem hiding this comment.
the syscall is only available on 64-bit (https://www.systutorials.com/docs/linux/man/2-arch_prctl/) so I assume the x32 was an error anyway.
| }) | ||
| fallthrough | ||
| case "x86": | ||
| case "386": |
There was a problem hiding this comment.
From the Go libseccomp library I don't see any arch "386"; they support "x32" for 32-bit Intel as far as I can tell?
There was a problem hiding this comment.
Sorry for the noise--just realized you are switching on runtime.GOARCH where 386 is correct
|
LGTM |
…e-ref Update to latest Windows SandboxImage
4 participants
Fixes missing default permission to allow sys call arch_prctl when runtime.GOARCH == amd64, was testing for "amd" not "amd64"
runtime.GOARC: "amd64" maps to (amd)
runtime.GOARC: "386" maps to (x86)
Signed-off-by: Mike Brown [email protected]