Skip to content

Close epoller on task delete#1529

Merged
mlaventure merged 2 commits intocontainerd:masterfrom
crosbymichael:console
Sep 20, 2017
Merged

Close epoller on task delete#1529
mlaventure merged 2 commits intocontainerd:masterfrom
crosbymichael:console

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Sep 20, 2017

This closes the epoller and bumps the console dep to allow it to be closed.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 20, 2017

Codecov Report

Merging #1529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   42.61%   42.61%           
=======================================
  Files          24       24           
  Lines        3318     3318           
=======================================
  Hits         1414     1414           
  Misses       1581     1581           
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d700a9c...7030a4a. Read the comment docs.

estesp
estesp approved these changes Sep 20, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume the Azure vendor removals are reasonable as appveyor ran and passed; I assume could have been a newer version of vndr or console update depended on less content in the Azure win-term library?

EDIT: nvm; I see the drop of import in the console update: https://github.com/containerd/containerd/pull/1529/files#diff-45aa7979a29beaa0a34768de2c01bc90L7

mlaventure
mlaventure approved these changes Sep 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 78c4e55 into containerd:master Sep 20, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
@mikebrow
Merge pull request containerd#1529 from AkihiroSuda/allow-disabling-h…
fcda0cf 
…ugepages

allow disabling hugepages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mlaventure mlaventure mlaventure approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crosbymichael @codecov-io @estesp @mlaventure