Add readme to contib#1519
Merged
mlaventure merged 1 commit intocontainerd:masterfrom Sep 18, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
=======================================
Coverage 40.85% 40.85%
=======================================
Files 23 23
Lines 2964 2964
=======================================
Hits 1211 1211
Misses 1466 1466
Partials 287 287Continue to review full report at Codecov.
|
mlaventure
reviewed
Sep 15, 2017
Contributor
There was a problem hiding this comment.
maybe add their stability is not warranted or similar?
Member
Author
There was a problem hiding this comment.
they may or may not be, its still in the repo so we still have somewhat of a responsibility for the code
estesp
approved these changes
Sep 18, 2017
Member
There was a problem hiding this comment.
minor typo: s/contib/contrib
End of sentence minor wording suggestion: "but still contribute to overall containerd usability." (drop the)
Closes containerd#1442 Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
contrib
branch
from
ccede58 to
58015ab
Compare
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
config: TolerateMissingHugePagesCgroupController -> TolerateMissingHugetlbController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1442
Signed-off-by: Michael Crosby [email protected]