Skip to content

Remove omitempty from toml tags#1517

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
mlaventure:remove-toml-omitempty
Sep 15, 2017
Merged

Remove omitempty from toml tags#1517
crosbymichael merged 1 commit intocontainerd:masterfrom
mlaventure:remove-toml-omitempty

Conversation

@mlaventure
Copy link
Copy Markdown
Contributor

The encoder only support changing the name of the key.

Signed-off-by: Kenfe-Mickael Laventure [email protected]

The encoder only support changing the name of the key.

Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 72f380a into containerd:master Sep 15, 2017
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files          23       23           
  Lines        2920     2920           
=======================================
  Hits         1192     1192           
  Misses       1451     1451           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfe3a9...f2d1459. Read the comment docs.

@mlaventure mlaventure deleted the remove-toml-omitempty branch September 26, 2017 15:30
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
hard set kubernetes version not in vendor.conf anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants