Skip to content

Add Akihiro as maintainer#1515

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:add-akihiro
Sep 18, 2017
Merged

Add Akihiro as maintainer#1515
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:add-akihiro

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Sep 15, 2017

Akihiro has proven himself as a valuable and dedicated contributor to Containerd. In addition he has also been maintaining moby core and buildkit. Having him as a maintainer makes sense and will be valuable in scaling review and maintenance of the project.

Maintainers:

BDFL:

Signed-off-by: Derek McGowan <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1515   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files          23       23           
  Lines        2920     2920           
=======================================
  Hits         1192     1192           
  Misses       1451     1451           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1d422...3596ec5. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

ping @AkihiroSuda

Is this something you want?

@AkihiroSuda
Copy link
Copy Markdown
Member

Yes, thank you!

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

3 similar comments
@mlaventure
Copy link
Copy Markdown
Contributor

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 15, 2017

LGTM

@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Sep 18, 2017

LGTM

@stevvooe
Copy link
Copy Markdown
Member

LGTM

I added a checklist above and it looks like it passes the threshold. I think we are missing approval from the BDFL @shykes.

@shykes
Copy link
Copy Markdown

shykes commented Sep 18, 2017

LGTM

1 similar comment
@lowenna
Copy link
Copy Markdown

lowenna commented Sep 18, 2017

LGTM

@crosbymichael crosbymichael merged commit f41871b into containerd:master Sep 18, 2017
@thaJeztah
Copy link
Copy Markdown
Member

Congrats (again) @AkihiroSuda 👍

@dmcgowan dmcgowan deleted the add-akihiro branch September 18, 2017 20:18
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.