Skip to content

Handle signals first on boot#1510

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:signals
Sep 15, 2017
Merged

Handle signals first on boot#1510
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:signals

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This handles signals first thing on boot so that plugins are able to
boot with the reaper enabled.

Signed-off-by: Michael Crosby [email protected]

@crosbymichael crosbymichael force-pushed the signals branch 2 times, most recently from a4a1783 to e8328b7 Compare September 14, 2017 20:18
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 14, 2017

Codecov Report

Merging #1510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files          23       23           
  Lines        2920     2920           
=======================================
  Hits         1192     1192           
  Misses       1451     1451           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1d422...7fdf8cd. Read the comment docs.

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, regardless of my comment

Comment thread cmd/containerd/main_unix.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, how did we get this duplicated between linux and unix? They're identical (linux should actually ignore SIGPIPE too)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

This handles signals first thing on boot so that plugins are able to
boot with the reaper enabled.

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 8ac9743 into containerd:master Sep 15, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants