Retrieve ctr missed events once connection is re-established#151
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Mar 24, 2016
Merged
Conversation
Member
|
needs rebase |
Member
|
LGTM |
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
mlaventure
force-pushed
the
ctr-retrieve-missed-events
branch
from
d0aeeae to
2b8ae55
Compare
Contributor
Author
|
Rebased |
jepio
pushed a commit
to jepio/containerd
that referenced
this pull request
Dec 3, 2021
bufio.Scanner.Err nits; mountinfo parser fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]
This still leave ctr hanging around if it's attach to a process that exits while
containerdis dead ifcontainerdis never restarted.I guess we could detect this since the
io.Copyforstdoutandstderrshould have been closed (but that'd require us not to open them withO_RDWRfromctr)