Support for multi-arch image unpacking#1506
Conversation
|
@dmcgowan Thanks~~~~ |
|
@dmcgowan I've pulled this PR down and confirmed that it will fix our CRI-Containerd CI test buckets. Just a couple lines of code to spec_opts_windows.go to get past the windows build break and good to go! |
|
@dmcgowan there is a windows build failure |
There was a problem hiding this comment.
Nit: Can we get something more explicit than ps? It usually makes me think of the ps command and hence processes
There was a problem hiding this comment.
platformSpecifier would be more explicit, maybe platform or psp ...
dmcgowan
force-pushed
the
unpack-manifest-list
branch
from
f0581bd to
bc0c368
Compare
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
=======================================
Coverage 40.82% 40.82%
=======================================
Files 23 23
Lines 2920 2920
=======================================
Hits 1192 1192
Misses 1451 1451
Partials 277 277Continue to review full report at Codecov.
|
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; similar nit to @mlaventure about more descriptive variable
Resolves the platform on multi-arch manifests during unpack and config resolving. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
unpack-manifest-list
branch
from
bc0c368 to
46ded63
Compare
|
@estesp @mlaventure he changed ps to platform, and fixed the windows build. Looks good to me. |
|
LGTM |
Add config for registry http headers
7 participants
Resolves the platform on multi-arch manifests during unpack and config resolving.