Skip to content

[tmp] Use amd64 test image#1502

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:test-image
Sep 13, 2017
Merged

[tmp] Use amd64 test image#1502
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:test-image

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This is a workaround because official images were pushed with multi-arch
support recently and the current Pull code is not accounting for this.

Signed-off-by: Michael Crosby [email protected]

This is a workaround because official images were pushed with multi-arch
support recently and the current Pull code is not accounting for this.

Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files          23       23           
  Lines        2920     2920           
=======================================
  Hits         1192     1192           
  Misses       1451     1451           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2aa4ec...ca3f16c. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

LGTM

Will make sure to update this back when we get the correct fix in

@crosbymichael crosbymichael merged commit 558b46f into containerd:master Sep 13, 2017
@crosbymichael crosbymichael deleted the test-image branch September 13, 2017 17:43
@ijc
Copy link
Copy Markdown
Contributor

ijc commented Sep 15, 2017

Can this be reverted now that #1506 is in? /cc @dmcgowan

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 15, 2017

I think @dmcgowan wanted to add one last enhancement to only pull layers/configs for the matching platform before we revert.

estesp added a commit to estesp/containerd that referenced this pull request Sep 21, 2017
…age"

This reverts commit 558b46f, reversing
changes made to 0e616f4.

Signed-off-by: Phil Estes <[email protected]>
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
move up to latest cri-tools - pick up nginx fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants