snapshot: use switch to parse snapshot.Kind#1463
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 5, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
=======================================
Coverage 40.82% 40.82%
=======================================
Files 23 23
Lines 2920 2920
=======================================
Hits 1192 1192
Misses 1451 1451
Partials 277 277Continue to review full report at Codecov.
|
dmcgowan
reviewed
Sep 1, 2017
Member
Author
There was a problem hiding this comment.
Na, we just go with this casing then flatten the case when parsing.
AkihiroSuda
reviewed
Sep 1, 2017
Signed-off-by: Stephen J Day <[email protected]>
stevvooe
force-pushed
the
switch-snapshot-kind
branch
from
bd77bc7 to
1c31199
Compare
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
…8s.io/kubernetes Remove dependencies on k8s.io/kubernetes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day [email protected]
@AkihiroSuda PTAL