Add daemon logging to file for tests#1451
Closed
crosbymichael wants to merge 1 commit intocontainerd:masterfrom
Closed
Add daemon logging to file for tests#1451crosbymichael wants to merge 1 commit intocontainerd:masterfrom
crosbymichael wants to merge 1 commit intocontainerd:masterfrom
Conversation
Its easier to debug when we have the daemon output logging to a file instead of dumping the output at the end via stderr. Signed-off-by: Michael Crosby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
======================================
Coverage 40.8% 40.8%
======================================
Files 23 23
Lines 2924 2924
======================================
Hits 1193 1193
Misses 1453 1453
Partials 278 278Continue to review full report at Codecov.
|
mlaventure
requested changes
Aug 31, 2017
| fmt.Fprintln(os.Stderr, "failed to remove test root dir", err) | ||
| os.Exit(1) | ||
| } | ||
| // only print containerd logs if the test failed |
Contributor
There was a problem hiding this comment.
Need to update CI to give it a log file to log to and print its content on exit.
stevvooe
approved these changes
Aug 31, 2017
Member
stevvooe
left a comment
stevvooe
left a comment
There was a problem hiding this comment.
LGTM
I like how this is test only.
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
…build-and-test split tests and some refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its easier to debug when we have the daemon output logging to a file
instead of dumping the output at the end via stderr.
Signed-off-by: Michael Crosby [email protected]