Allow setting runtime options when using WithRuntime()#1439
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 30, 2017
Merged
Allow setting runtime options when using WithRuntime()#1439estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
mlaventure
force-pushed
the
allow-setting-rutime-opts
branch
from
d39f34f to
6ef8700
Compare
Member
There was a problem hiding this comment.
Maybe take an interface here and we will do the Any marshal with the types package
Contributor
Author
There was a problem hiding this comment.
yeah, I hesitated to do so. I guess I should have.
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
mlaventure
force-pushed
the
allow-setting-rutime-opts
branch
from
6ef8700 to
42b131c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
======================================
Coverage 40.8% 40.8%
======================================
Files 23 23
Lines 2924 2924
======================================
Hits 1193 1193
Misses 1453 1453
Partials 278 278Continue to review full report at Codecov.
|
Member
|
LGTM |
mauriciovasquezbernal
pushed a commit
to kinvolk/containerd
that referenced
this pull request
Nov 13, 2020
fixes bad unit test when selinux is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]
--
Will be needed by docker to set
system-cgroupon the runc binary