Skip to content

Add default apparmor profile generation#1438

Merged
mlaventure merged 1 commit intocontainerd:masterfrom
crosbymichael:apparmor
Aug 29, 2017
Merged

Add default apparmor profile generation#1438
mlaventure merged 1 commit intocontainerd:masterfrom
crosbymichael:apparmor

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This adds default apparmor profile generation to the containerd client
so that profiles can be generated with a SpecOpt

Added this in a contrib directory for Opt organization.

Signed-off-by: Michael Crosby [email protected]

This adds default apparmor profile generation to the containerd client
so that profiles can be generated with a SpecOpt

Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1438   +/-   ##
======================================
  Coverage    40.8%   40.8%           
======================================
  Files          23      23           
  Lines        2924    2924           
======================================
  Hits         1193    1193           
  Misses       1453    1453           
  Partials      278     278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec92dd...2b46989. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure
Copy link
Copy Markdown
Contributor

mlaventure commented Aug 29, 2017

LGTM

But, what are the rules of this folder? For instance, there's no test coming with those options 😇

Created #1442 for that :)

@mlaventure mlaventure merged commit 456e169 into containerd:master Aug 29, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
Replace docker/distribution/reference with containerd/reference/docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants