Skip to content

Add security mailing list to readme and releases#1436

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:security
Aug 29, 2017
Merged

Add security mailing list to readme and releases#1436
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:security

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Aug 28, 2017 •
edited
Loading

Signed-off-by: Michael Crosby [email protected]

Closes #1337

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2017 •
edited
Loading

Codecov Report

Merging #1436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1436   +/-   ##
======================================
  Coverage    40.8%   40.8%           
======================================
  Files          23      23           
  Lines        2924    2924           
======================================
  Hits         1193    1193           
  Misses       1453    1453           
  Partials      278     278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf09e32...6b6ac8e. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Aug 28, 2017

LGTM

@crosbymichael
Copy link
Copy Markdown
Member Author

crosbymichael commented Aug 28, 2017

As a first step, all maintainers should have received an invite to this group.

estesp
estesp approved these changes Aug 28, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mlaventure
mlaventure requested changes Aug 28, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which guidelines?

http://www.cert.org/vulnerability-analysis/vul-disclosure.cfm ?

Copy link
Copy Markdown
Member Author

@crosbymichael crosbymichael Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I copied this from the RELEASE doc

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's @stevvooe when you need him :trollface:

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Aug 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting security issues ?

@crosbymichael
Copy link
Copy Markdown
Member Author

crosbymichael commented Aug 29, 2017

@mlaventure fixed

mlaventure
mlaventure approved these changes Aug 29, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we'd need to link or provide the guidelines.

But we can do so in a subsequent PR.

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 29, 2017

Yeah, I think we can add detail re: guidelines as a follow-on.

@estesp estesp merged commit 7dd87c3 into containerd:master Aug 29, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
@mikebrow
Merge pull request containerd#1436 from chethanah/add-container-name-…
9d37687 
…annot

Support for additional OCI annotations: 'container-name'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mlaventure mlaventure mlaventure approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crosbymichael @codecov-io @dmcgowan @estesp @mlaventure