Repository navigation
[release/2.4] ctr: preserve args after "-" in images export - #14219
Merged
samuelkarp merged 1 commit intoSep 24, 2026
Merged
samuelkarp merged 1 commit into
samuelkarp merged 1 commit into
Conversation
urfave/cli/v3 breaks out of its flag parsing loop when it encounters a "-" positional argument without appending the remaining arguments, causing "ctr images export - <image>" to drop all image references and flags following "-". When <out> is "-", recover the un-truncated arguments from the parent "images" command lineage and re-parse the tail starting at "-" with a sentinel placeholder so trailing image references and flags are preserved. This workaround can be removed after the bug is fixed upstream: * urfave/cli#2418 * urfave/cli#2419 Assisted-by: Antigravity Signed-off-by: Samuel Karp <[email protected]>
thaJeztah
approved these changes
Sep 24, 2026
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM (assuming CI is happy)
samuelkarp
approved these changes
Sep 24, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #14217
/assign thaJeztah